Skip to content

Write 3 ms digits to ascii to resolve CANoe bug #1362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 11, 2022
Merged

Write 3 ms digits to ascii to resolve CANoe bug #1362

merged 4 commits into from
Aug 11, 2022

Conversation

j-c-cook
Copy link
Contributor

@j-c-cook j-c-cook commented Aug 6, 2022

  • The ascii writer will now only write 3 micro second decimal places to a log file.
  • The ascii format currently is not setup to append. I recenly added in **options to the logger script. **options are only required for
    the rolling logger.

closes #1315
closes #1357

j-c-cook added 2 commits August 6, 2022 11:31
@j-c-cook
Write 3 ms to ascii for CANoe and fix append error
57af021 
The ascii format currently is not setup to append. I recenly added
in **options to the logger script. **options are only required for
the rolling logger.
@j-c-cook
Black and mypy fixes
9c088e2
@codecov
Copy link

codecov bot commented Aug 6, 2022 •
edited
Loading

Codecov Report

Merging #1362 (44b0489) into develop (88fc8e5) will increase coverage by 0.05%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop    #1362      +/-   ##
===========================================
+ Coverage    66.13%   66.18%   +0.05%     
===========================================
  Files           86       86              
  Lines         9004     9006       +2     
===========================================
+ Hits          5955     5961       +6     
+ Misses        3049     3045       -4

@j-c-cook
Copy link
Contributor Author

j-c-cook commented Aug 6, 2022

@zariiii9003 ready for review.

@j-c-cook j-c-cook marked this pull request as ready for review August 6, 2022 16:43
j-c-cook
j-c-cook commented Aug 6, 2022
View reviewed changes
@j-c-cook j-c-cook marked this pull request as draft August 6, 2022 19:35
zariiii9003
zariiii9003 reviewed Aug 11, 2022
View reviewed changes
zariiii9003
zariiii9003 reviewed Aug 11, 2022
View reviewed changes
@j-c-cook
Copy link
Contributor Author

j-c-cook commented Aug 11, 2022 •
edited
Loading

@zariiii9003 I believe this is a fix for the bug described in #1315.

@j-c-cook j-c-cook marked this pull request as ready for review August 11, 2022 19:36
@j-c-cook j-c-cook changed the title Write 3 ms to ascii for CANoe and fix append error Write 3 ms digits to ascii to resolve CANoe bug Aug 11, 2022
@j-c-cook
Copy link
Contributor Author

j-c-cook commented Aug 11, 2022 •
edited
Loading

At a glance, I'm not sure how the test failure of mypy --python-version 3.8 . has to do with these minor changes. The datetime documentation says strftime returns a string, and I have operated on it with string compatible functions (index and replace).

@zariiii9003
Copy link
Collaborator

At a glance, I'm not sure how the test failure of mypy --python-version 3.8 . has to do with these minor changes. The datetime documentation says strftime returns a string, and I have operated on it with string compatible functions (index and replace).

I just ran into this issue, too. It's weird because nothing changed. I'll try to fix it.

@zariiii9003
Copy link
Collaborator

Should be fixed in develop.

@zariiii9003 zariiii9003 merged commit 3a7c80e into hardbyte:develop Aug 11, 2022
@j-c-cook j-c-cook deleted the issue1315_asc_playback_canoe branch August 11, 2022 22:02
@Tian-Jionglu
Copy link

@j-c-cook as mentioned in #1357, script can_logconvert.py makes logged datetime in converted asc file as converting datetime. Does anyone else also think it is weird?

@zariiii9003
Copy link
Collaborator

@j-c-cook as mentioned in #1357, script can_logconvert.py makes logged datetime in converted asc file as converting datetime. Does anyone else also think it is weird?

I'm not sure what you mean, could you give an example? Or attach the files maybe?

@Tian-Jionglu
Copy link

See logs header below:

  • ascii logged by python-can can_logger.py
date Thu Aug 04 03:17:23.124 PM 2022
base hex  timestamps absolute
internal events logged
Begin Triggerblock Thu Aug 04 03:17:23.120 PM 2022
  • ascii logged by CANalyzer
date Mon Aug 15 09:32:44.632 am 2022
base hex  timestamps absolute
internal events logged
// version 11.0.0
Begin Triggerblock Mon Aug 15 09:32:44.632 am 2022
  • ascii converted by python-can can_logconvert.py
date Sat Aug 13 09:09:58.794 AM 2022
base hex  timestamps absolute
internal events logged
Begin Triggerblock Thu Aug 04 12:44:31.611 PM 2022

We can see that in log from CANalyzer, log datetime is the same as trigger beginning datetime.
But in python-can these two datetimes are different, this differs a lot when using logconvert.

@Tian-Jionglu
Copy link

@zariiii9003, what's your opinion?

@zariiii9003
Copy link
Collaborator

I see what you mean now. Technically the current implementation is correct, The header tells when the file was created and the triggerblock tells the timestamp of the first message.

But i'd like to hear other opinions on this.

@j-c-cook j-c-cook mentioned this pull request Nov 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zariiii9003 zariiii9003 zariiii9003 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Logged .asc file can't open in CANoe 14
3 participants
@j-c-cook @zariiii9003 @Tian-Jionglu